Re: [PATCH 1/2 v2] fs: Return EAGAIN when O_NONBLOCK write should block on frozen fs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 08, 2012 at 01:41:37PM +0100, Jan Kara wrote:
> When user asks for O_NONBLOCK behavior for a file descriptor, return
> EAGAIN instead of blocking on a frozen filesystem.
> 
> Signed-off-by: Jan Kara <jack@xxxxxxx>
> ---
>  fs/btrfs/file.c    |    3 ++-
>  fs/cifs/file.c     |    3 ++-
>  fs/fuse/file.c     |    3 ++-
>  fs/ntfs/file.c     |    3 ++-
>  fs/ocfs2/file.c    |    3 ++-
>  fs/xfs/xfs_file.c  |    3 ++-
>  include/linux/fs.h |   10 ++++++++++
>  mm/filemap.c       |    3 ++-
>  8 files changed, 24 insertions(+), 7 deletions(-)

Looks good, though you missed generic_file_splice_write(). Shouldn't
this also return EAGAIN?

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux