>>>>> "Phillip" == Phillip Lougher <phillip.lougher@xxxxxxxxx> writes: Hi, Phillip> The patches in question are adding a new feature to Squashfs. Phillip> New features are always nice to have, but always carry the Phillip> risk of introducing bugs, performance regressions, and Phillip> generally making the code harder to maintain if (as is the Phillip> case with these patches) they have been implemented in a way Phillip> not to my liking. Phillip> I reviewed these patches when they arrived, and I got a poor Phillip> opinion of them. However, I decided to give the patches a Phillip> chance, and wait and see what feedback/code-review they got. Phillip> So far they have received nothing. I would also prefer to see direct mtd support instead of through mtdblock if anything rather than this direct memory access. -- Bye, Peter Korsgaard -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
