On Sun 13-05-12 14:26:40, Hugh Dickins wrote: > In looking through hole-punching implementations, I got the impression > that perhaps ext4 and ocfs2 might need to inode_dio_wait() before they > truncate pagecache. And that might require ext4 to hold i_mutex there? Not necessarily before truncating page cache AFAICS but certainly before we go and remove blocks from the file. In case of ext4 doing that before ext4_flush_completed_IO() call would look most appropriate I'd think. Good spotting! Will you send a patch? Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html