On Wed, Mar 28, 2012 at 11:12:47AM -0400, Christoph Hellwig wrote: > On Wed, Mar 28, 2012 at 11:11:54AM +0800, Fengguang Wu wrote: > > Cannot speak for AFS, however I don't see the difference, either. > > Why would afs_fsync/afs_setattr need to keep the inode in dirty list? > > It seems fine to just remove that line? > > All of afs_fsync looks bogus to me. I'd take a bet that if you > removed everything but the filemap_write_and_wait_range call it would > still work exactly as it did before. Is there a good testsuite for afs? Dave, any chance to get your input on afs_fsync? I think it could and should be dramatically simplified. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
