Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: > On Tue, Mar 13, 2012 at 12:22:10PM +0100, Miklos Szeredi wrote: >> Good point. Yes, ->create is probably worth getting rid of. Mkdir, I'm >> not so sure, but I'll look at what filesystems are doing. > > Btw, is there any good reason to keep ->atomic_open and ->atomic_create > separate? It seems like the instances in general share code anyway. ->atomic_open is called before lookup, ->atomic_create after lookup. How would we differentiate between the two if they were common? We could have a filesystem flag, but for example CEPH does weird things like using ->atomic_open for !O_CREAT and ->atomic_create for O_CREAT. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
