On Wed, Mar 07, 2012 at 10:22:26PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@xxxxxxx>
>
> Make nfs_atomic_open() work for non-open creates. This is trivial to do and
> allows the NFSv4 specific create code to be removed.
>
> Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
> ---
> fs/nfs/dir.c | 28 ++++++++++++++++++++--------
> fs/nfs/nfs4proc.c | 31 -------------------------------
> 2 files changed, 20 insertions(+), 39 deletions(-)
>
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 24bf3c9..8627965 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -114,10 +114,13 @@ const struct inode_operations nfs3_dir_inode_operations = {
> static struct file *nfs_atomic_open(struct inode *, struct dentry *,
> struct opendata *, unsigned, umode_t,
> bool *);
> +static struct file *nfs_atomic_open_common(struct inode *, struct dentry *,
> + struct opendata *, unsigned,
> + umode_t);
> const struct inode_operations nfs4_dir_inode_operations = {
> - .create = nfs_create,
> .lookup = nfs_lookup,
> .atomic_open = nfs_atomic_open,
> + .atomic_create = nfs_atomic_open_common, /* called for mknod */
Can you please name the methods after the interface they implement,
e.g. do a s/nfs_atomic_open_common/nfs_atomic_create/g here, and
similar transformations for the other filesystems.
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
