On Tue, Feb 21, 2012 at 10:04:55PM +0000, Al Viro wrote: > What we need to do is either > * silently return 0 on thislen > QNX6_LONG_NAME_MAX, or > * return 0 and yell about corrupt /longfiles, or > * have qnx6_lookup() check that len <= QNX6_LONG_NAME_MAX and > return ERR_PTR(-ENAMETOOLONG) if it isn't. And lose the thislen check > completely. > > I'd probably go for the last variant; it's consistent with what other > filesystems are doing and it would avoid mess if we ever try to do > r/w variant. Oh, wait - you already are doing that in ->lookup()? Then it's definitely "let's lose thislen checks in qnx6_long_match() and qnx6_match()". Dead code is dead code... Pushed with that correction. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
