> On Fri, Feb 17, 2012 at 04:06:19PM +0100, Kai Bankett wrote: > > + bh1 = sb_bread(s, s->s_blocksize); > in there looks rather fishy... Fixed. > > qnx6_lfile_checksum() doesn't use superblock argument anymore (used to > be used for conversion, but since you are passing length from the > caller...) > > qnx6_longname() - since you are passing superblock anyway, sbi is > redundant... Removed. > > FWIW, I would probably simply do (inode->i_size + 511) >> 9 and devil > take the rounding effects on big block sizes; it's an approximation > anyway, since you are not counting indirect blocks... > Changed. Fair enough and safes cpu cycles. > Other than that (and assuming it survives your testing), I'm fine with > that variant. At least no problems with all my test images. Just ran a complete test (file reads, dir(s), filepermissions, symlink, hardlink, longfilenames, longdirectories etc.) over (mmi/be/le/1k/2k blocksize images). http://a6.ontika.net/patches/0001-fs-initial-qnx6fs-addition.patch.gz -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
