On Wed, Jan 18, 2012 at 1:40 PM, Tyler Hicks <tyhicks@xxxxxxxxxxxxx> wrote: > > mm/filemap.c uses unsigned long for variables used to identify an offset > into a single page. That's what I'm tempted to use for offset_in_page, > rather than loff_t. Indeed. The offset within a page will fit fine even in an "unsigned int", and "loff_t" is crazy overkill - and usually generates horrible code on 32-bit architectures. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html