On Wed, 2012-01-11 at 16:19 +0000, Al Viro wrote:
> Looking at the callers, I'm not sure we want that warning in set_nlink()
> at all, rate-limited or not. Note that it can trigger on the things
> like stale NFS fhandle coming in for something that had been deleted
> a while ago - IOW, it's neither a kernel bug nor fs corruption.
> inc_nlink - sure, that might catch real bugs, drop_nlink - definitely,
> but this...
Patch follows.
Thanks,
Miklos
----
Subject: vfs: remove printk from set_nlink()
From: Miklos Szeredi <mszeredi@xxxxxxx>
Don't log a message for set_nlink(0).
Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx>
---
fs/inode.c | 3 ---
1 file changed, 3 deletions(-)
Index: linux-2.6/fs/inode.c
===================================================================
--- linux-2.6.orig/fs/inode.c 2012-01-11 10:55:00.000000000 +0100
+++ linux-2.6/fs/inode.c 2012-01-12 12:32:44.000000000 +0100
@@ -322,9 +322,6 @@ EXPORT_SYMBOL(clear_nlink);
void set_nlink(struct inode *inode, unsigned int nlink)
{
if (!nlink) {
- printk_ratelimited(KERN_INFO
- "set_nlink() clearing i_nlink on %s inode %li\n",
- inode->i_sb->s_type->name, inode->i_ino);
clear_nlink(inode);
} else {
/* Yes, some filesystems do change nlink from zero to one */
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
