On Wed, 2012-01-11 at 06:58 -0500, Christoph Hellwig wrote: > On Sun, Jan 08, 2012 at 03:04:30PM -0800, Linus Torvalds wrote: > > Hmm. > > > > Al, Miklos, I just triggered the new inc_link() warning three times in > > very close succession by just doing a simple > > Also just as expected the set_nlink warnings triggers during XFS log > recovery (not that I haven't pointed this out multiple times before): > > [ 1702.280003] XFS (vdb2): Starting recovery (logdev: internal) > [ 1702.294935] set_nlink() clearing i_nlink on xfs inode 320 > [ 1702.297909] set_nlink() clearing i_nlink on xfs inode 256 > [ 1702.301082] set_nlink() clearing i_nlink on xfs inode 192 > [ 1702.304305] set_nlink() clearing i_nlink on xfs inode 321 > [ 1702.306980] set_nlink() clearing i_nlink on xfs inode 257 > [ 1702.308204] set_nlink() clearing i_nlink on xfs inode 193 > [ 1702.309490] set_nlink() clearing i_nlink on xfs inode 322 > [ 1702.311195] set_nlink() clearing i_nlink on xfs inode 258 > [ 1702.313156] set_nlink() clearing i_nlink on xfs inode 194 > [ 1702.315203] set_nlink() clearing i_nlink on xfs inode 323 There are a couple of options: a) leave it as it is b) change that set_nlink() in xfs into a if (nlink) set_nlink(nlink); else clear_nlink(); c) remove the printk from set_nlink(). This effectively makes set_nlink(0) an alias of clear_nlink(). IIRC your preference is c. What do others think? Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
