Re: [git pull] apparmor fix for __d_path() misuse

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 6, 2011 at 4:39 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> IOW, I mean this:

Yeah, no.

> +       if (ancestor) {
> +               ancestor->mnt = mntget(vfsmnt);
> +               ancestor->dentry = dget(dentry);
> +       }

This part is still just pure and utter sh*t.

You have not explained why that information is *ever* valid. And I
claim it isn't.

We have a bug in our current __d_path(). And I claim that the
underlying cause of the bug is the crazy "let's return this
nonsensical and idiotic information that cannot possibly make sense to
anybody".

We shouldn't have done that in the first place. And we certainly
shouldn't *continue* doing that.

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux