On Wed, 2011-11-30 at 06:50 +0000, Al Viro wrote: > - if (!(page = __get_free_page(GFP_KERNEL))) > + page = __get_free_page(GFP_KERNEL); > + if (!page) > return -ENOMEM; > Not sure... In general I'd agree, but in this case... Shrug. I'm not sure there's much of a case other than line count for keeping this a one-liner. If you want these sorts of changes to be redone after vfsmount-guts gets promoted, let me know. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html