On Tue, Nov 29, 2011 at 06:14:14PM -0800, Joe Perches wrote: > Fix a few style things. > > $ ./scripts/checkpatch.pl -f --terse --nosummary fs/namespace.c | \ > cut -f3- -d":" | sort | uniq -c > 1 ERROR: do not initialise statics to 0 or NULL > 2 ERROR: do not use assignment in if condition > 1 ERROR: "foo * bar" should be "foo *bar" > 1 ERROR: need consistent spacing around '|' (ctx:VxW) > 1 WARNING: braces {} are not necessary for single statement blocks > 3 WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable > 4 WARNING: line over 80 characters > 9 WARNING: please, no space before tabs > 1 WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h> > 1 WARNING: Use #include <linux/unistd.h> instead of <asm/unistd.h> NAK. First of all, wanking it certainly is; moreover, it creates shitloads of conflicts with patches in vfs.git#vfsmount-guts -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html