On Fri, Sep 16, 2011 at 22:07 +0400, Cyrill Gorcunov wrote: > > BTW, not a big deal, but probably you should return -EACCES on > > !capable() as file presence is not an issue in this case. > > > > if (!ptrace_may_access(task, PTRACE_MODE_READ)) > > goto out_notask; > > > > status = -EACCES; > > if (!capable(CAP_SYS_ADMIN)) > > goto out_notask; > > > > status = 0; > > > > > > That's not a proble to fix it actually. So can I fix it and > put some tage here (Reviewed or something?). Yep, with CAP_SYS_ADMIN check there should be no issues here. Reviewed-by: Vasiliy Kulikov <segoon@xxxxxxxxxxxx> Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
