On Thu, Sep 8, 2011 at 12:23 PM, Seth Forshee <seth.forshee@xxxxxxxxxxxxx> wrote: > On Thu, Sep 08, 2011 at 04:13:01AM +0100, Hin-Tak Leung wrote: >> --- On Wed, 7/9/11, Seth Forshee <seth.forshee@xxxxxxxxxxxxx> wrote: >> >> > Yes, that was definitely just an oversight. Has anyone >> > provided a patch >> > yet? If not I've pasted a patch below. Seems like a fix >> > should be >> > applied ASAP. >> > >> > >> > From d27825b880028e9a45ba640d86c9e8101db0606b Mon Sep 17 >> > 00:00:00 2001 >> > From: Seth Forshee <seth.forshee@xxxxxxxxxxxxx> >> > Date: Wed, 7 Sep 2011 10:38:35 -0700 >> > Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in >> > hfsplus_fill_super() error path >> > >> > Commit 6596528 (hfsplus: ensure bio requests are not >> > smaller than >> > the hardware sectors) changed the pointers used for volume >> > header >> > allocations but failed to change the pointer freed in the >> > error >> > path of hfsplus_fill_super(). This patch fixes the >> > problem. >> > >> > Reported-by: Pavel Ivanov <paivanof@xxxxxxxxx> >> > Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx> >> > Cc: <stable@xxxxxxxxxx> >> >> Acked-by: Hin-Tak Leung <htl10@xxxxxxxxxxxxxxxxxxxxx> >> >> Please go ahead and submit the patch. > > That was my patch submission :) > > Christoph, does that work for you, or would you like me to send the > patch in a separate email? Seth, Christoph, I've just found another wrong pointers freeing. The following patch should fix it. Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in hfsplus_read_wrapper() error path Commit 6596528 (hfsplus: ensure bio requests are not smaller than the hardware sectors) changed the pointers used for volume header allocations but failed to change the pointer freed in the error path of hfsplus_read_wrapper(). This patch fixes the problem. Signed-off-by: Pavel Ivanov <paivanof@xxxxxxxxx> Cc: <stable@xxxxxxxxxx> --- diff --git a/fs/hfsplus/wrapper.c b/fs/hfsplus/wrapper.c index 10e515a..7daf4b8 100644 --- a/fs/hfsplus/wrapper.c +++ b/fs/hfsplus/wrapper.c @@ -272,9 +272,9 @@ reread: return 0; out_free_backup_vhdr: - kfree(sbi->s_backup_vhdr); + kfree(sbi->s_backup_vhdr_buf); out_free_vhdr: - kfree(sbi->s_vhdr); + kfree(sbi->s_vhdr_buf); out: return error; } -- -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
