--- On Wed, 7/9/11, Seth Forshee <seth.forshee@xxxxxxxxxxxxx> wrote: > Yes, that was definitely just an oversight. Has anyone > provided a patch > yet? If not I've pasted a patch below. Seems like a fix > should be > applied ASAP. > > > From d27825b880028e9a45ba640d86c9e8101db0606b Mon Sep 17 > 00:00:00 2001 > From: Seth Forshee <seth.forshee@xxxxxxxxxxxxx> > Date: Wed, 7 Sep 2011 10:38:35 -0700 > Subject: [PATCH] hfsplus: Fix kfree of wrong pointers in > hfsplus_fill_super() error path > > Commit 6596528 (hfsplus: ensure bio requests are not > smaller than > the hardware sectors) changed the pointers used for volume > header > allocations but failed to change the pointer freed in the > error > path of hfsplus_fill_super(). This patch fixes the > problem. > > Reported-by: Pavel Ivanov <paivanof@xxxxxxxxx> > Signed-off-by: Seth Forshee <seth.forshee@xxxxxxxxxxxxx> > Cc: <stable@xxxxxxxxxx> Acked-by: Hin-Tak Leung <htl10@xxxxxxxxxxxxxxxxxxxxx> Please go ahead and submit the patch. > --- > fs/hfsplus/super.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/hfsplus/super.c b/fs/hfsplus/super.c > index c106ca2..cadbb8c 100644 > --- a/fs/hfsplus/super.c > +++ b/fs/hfsplus/super.c > @@ -525,8 +525,8 @@ out_close_cat_tree: > out_close_ext_tree: > hfs_btree_close(sbi->ext_tree); > out_free_vhdr: > - kfree(sbi->s_vhdr); > - kfree(sbi->s_backup_vhdr); > + kfree(sbi->s_vhdr_buf); > + kfree(sbi->s_backup_vhdr_buf); > out_unload_nls: > unload_nls(sbi->nls); > unload_nls(nls); > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe > linux-fsdevel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
