Re: [PATCH 3 2/4] Return 32/64-bit dir name hash according to usage type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2011-08-19, at 4:29 PM, Ted Ts'o wrote:
> On Tue, Aug 16, 2011 at 01:54:14PM +0200, Bernd Schubert wrote:
>> +static inline int is_32bit_api(void)
>> +{
>> +#ifdef HAVE_IS_COMPAT_TASK
>> +	return is_compat_task();
>> +#else
>> +	return (BITS_PER_LONG == 32);
>> +#endif
> 
> I assume is_compat_task() is coming from another patch?  What is the
> status of that change?

No, is_compat_task() is upstream for most (all?) of the architectures
that support hybrid 32-/64-bit operation.  It is set at 32-bit syscall
entry when running on 64-bit architectures.

The only minor error in this patch (fixed with a new version from Bernd)
is that this should be under CONFIG_COMPAT instead of HAVE_IS_COMPAT_TASK.

> In the case where is_compat_task() is not defined, we can't just test
> based on BITS_PER_LONG == 32, since even on an x86_64 machine, it's
> possible we're running a 32-bit binary in compat mode....

It is definitely available on x86_64.

Cheers, Andreas
--
Andreas Dilger 
Principal Engineer
Whamcloud, Inc.



--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux