undefined behaviour in fs/jbd*/revoke.c:hash()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



hi guys,

with a clang compiled kernel while enabling -fcatch-undefined-behavior one gets
a runtime assert in find_revoke_record(), more precisely, in the inlined hash()
function.

the issue is that one of the expressions is 'hash << (hash_shift - 12)' which is
undefined (in C99 at least) when the shift count is negative and it so happens
that hash_shift is 8 because JOURNAL_REVOKE_DEFAULT_HASH is defined to be 256.

i'm not sure what the right fix would be hence this mail ;). JOURNAL_REVOKE_DEFAULT_HASH
could be increased to 4096 (or more) to avoid the negative shift or the shift
count should be fixed to become explicitly non-negative. also given the comment
above the hash() function, this construct may be used elsewhere as well, i didn't
check myself but it might be worth a look.

cheers,
 PaX Team

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux