On Thu, Mar 17, 2011 at 03:48:13PM -0700, Tony Luck wrote: > On Thu, Mar 17, 2011 at 3:42 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote: > >> + ? ? memcpy(private->data, data, size); > >> + ? ? inode->i_size = private->size = size; > >> > >> ? ? ? inode->i_private = private; > > > > Better move that before d_add() > > Will do. > > > *blink* > > ? ? ? ?if (IS_ERR(root)) > > ? ? ? ? ? ? ? ?return root; > > ? ? ? ?return root; > > > > ... or am I misreading the patch? > > Your patch reading skills are fine ... the code deserves more than a *blink*. > Will fix. Send the updated patch my way, please. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
