Re: Some fixes for pstore (Was Re: [git pull] mnt_devname queue)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 17, 2011 at 3:42 PM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>> +     memcpy(private->data, data, size);
>> +     inode->i_size = private->size = size;
>>
>>       inode->i_private = private;
>
> Better move that before d_add()

Will do.

> *blink*
>        if (IS_ERR(root))
>                return root;
>        return root;
>
> ... or am I misreading the patch?

Your patch reading skills are fine ... the code deserves more than a *blink*.
Will fix.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux