On Wed, Mar 16, 2011 at 11:49:31AM -0700, Linus Torvalds wrote: > On Wed, Mar 16, 2011 at 11:17 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > >> > >> "doesn't need" or "must not have"? > > > > It must not have one, otherwise refcounting will go astray. > > That's what I thought. The commit message just seemed to be off. > > > That cdev_put() should really be moved into f_op->release(), but that > > would be quite a bit of work. > > Yeah. Al? In tree, with edited commit message... Please, pull from git.kernel.org/pub/scm/linux/kernel/git/viro/vfs-2.6.git/ for-linus (just one commit in that branch) -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html