On Wed, 16 Mar 2011, Linus Torvalds wrote: > On Wed, Mar 16, 2011 at 10:17 AM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > > __fput doesn't need a cdev_put() for O_PATH handles. > > "doesn't need" or "must not have"? It must not have one, otherwise refcounting will go astray. That cdev_put() should really be moved into f_op->release(), but that would be quite a bit of work. Thanks, Miklos -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html