On Thu, Feb 17, 2011 at 02:07:00PM -0500, Trond Myklebust wrote: > Hi Al, > > That is probably a remnant of the times before lookup_create() was > changed to set the LOOKUP_CREATE intent in 2.6.18. > > I'm fine with getting rid of those checks if they are no longer needed. Um... You mean, before we had .open.flags set to O_EXCL in there? Makes sense - it's about 3 years older than lookup_create() change. OK, then I'm going to remove the checks (treating condition as always true) and place BUG_ON for a few months just in case... -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html