On Thu, 2011-02-17 at 03:37 +0000, Al Viro wrote: > When are they _not_ true? AFAICS, calls of ->create() with > non-NULL nameidata are very limited to start with: > * ecryptfs one - called from its own ->create(), without changes > in LOOKUP_CREATE presence. > * sys_mknodat() - called after we'd done lookup_create(), which > sets LOOKUP_CREATE (and LOOKUP_EXCL), with O_EXCL in intent flags. Nothing > ever removes LOOKUP_CREATE once it's set. > * __open_namei_create(), which is called from from do_filp_open() > and only if we had O_CREAT passed in flags. In that case LOOKUP_CREATE > will be set before we get there. > > What am I missing here? AFAICS, there's no way to get nfs ->create() methods > called without LOOKUP_CREATE present in nd->flags... Hi Al, That is probably a remnant of the times before lookup_create() was changed to set the LOOKUP_CREATE intent in 2.6.18. I'm fine with getting rid of those checks if they are no longer needed. Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp Trond.Myklebust@xxxxxxxxxx www.netapp.com -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
