"Andrew Morton" <akpm@xxxxxxxxxxxxxxxxxxxx> wrote: >I've looked at this warning several times - the code is non-buggy and >it's a bit sad to add extra instructions unnecessarily. It would be >better to make this warning go away by cleaning up or restructuring the >code. > >And the code _is_ pretty stupid. If timed_out is set to 1 then the >function does a great pile of useless junk. I had a quick tinkle, made >things worse and gave up: [snip] >I think the attempt to munge the "timeout==0" spacial case into the >main body of the polling loop was a mistake, and that the code would be >better/cleaner if that special case was handled quite separately. I can have a go at a patch later on today if you wish. Thanks, Jack -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
