[cc Al Viro and Shawn Bohrer] On 14/01/2011 11:52, Viresh Kumar wrote: > This patch fixes following compilation warning > fs/eventpoll.c:1119: warning: 'slack' may be used uninitialized in this function > > Signed-off-by: Viresh Kumar <viresh.kumar@xxxxxx> > --- > fs/eventpoll.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/eventpoll.c b/fs/eventpoll.c > index 8cf0724..89b5e98 100644 > --- a/fs/eventpoll.c > +++ b/fs/eventpoll.c > @@ -1116,7 +1116,7 @@ static int ep_poll(struct eventpoll *ep, struct epoll_event __user *events, > { > int res, eavail, timed_out = 0; > unsigned long flags; > - long slack; > + long uninitialized_var(slack); > wait_queue_t wait; > struct timespec end_time; > ktime_t expires, *to = NULL; Hi Viresh, This is certainly the correct thing to do if timeout cannot be negative. Al, Shawn Can timeout be negative, and if so what does it mean? Thanks, Jack -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html