On Fri, Jan 14, 2011 at 01:07:43PM +0100, Christoph Hellwig wrote: > Currently all filesystems except XFS implement fallocate asynchronously, > while XFS forced a commit. Both of these are suboptimal - in case of O_SYNC > I/O we really want our allocation on disk, especially for the !KEEP_SIZE > case where we actually grow the file with user-visible zeroes. On the > other hand always commiting the transaction is a bad idea for fast-path > uses of fallocate like for example in recent Samba versions. Given > that block allocation is a data plane operation anyway change it from > an inode operation to a file operation so that we have the file structure > available that lets us check for O_SYNC. > > This also includes moving the code around for a few of the filesystems, > and remove the already unnedded S_ISDIR checks given that we only wire > up fallocate for regular files. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Everything looks right, Reviewed-by: Josef Bacik <josef@xxxxxxxxxx> Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
