On Fri, Oct 08, 2010 at 07:06:55PM +1100, Dave Chinner wrote: > On Fri, Oct 08, 2010 at 03:55:24AM -0400, Christoph Hellwig wrote: > > > + hlist_bl_for_each_entry(inode, node, &b->head, i_hash) { > > > + if (inode->i_ino == ino && inode->i_sb == sb) { > > > > wouldn't it be more natural to test the sb first here? > > Maybe, but I think an inode number match is less likely, so the > order it currently does the check results in less code being > executed on misses. Ok, sounds fine. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html