Hi.
On 19/08/10 13:47, Hugh Dickins wrote:
On Wed, 18 Aug 2010, Christoph Hellwig wrote:
The swap code already uses synchronous discards, no need to add I/O barriers.
Signed-off-by: Christoph Hellwig<hch@xxxxxx>
Acked-by: Hugh Dickins<hughd@xxxxxxxxxx>
(though if you happened to respin, I'd be be glad for those newlines
between GFP_KERNEL, BLKDEV_IFL_WAIT to go away now)
This patch could go in any time now: I may want to push it in and
get it to 35-stable, because it certainly helps against the swap
discard regression that Nigel reported (though I've not yet seen
his numbers with this). However, I don't think it eliminates the
regression, so I've more testing and experimenting to do before
deciding about it - the right answer may just be to disable swap
discard, as you asked for long ago.
That's correct. The patch reduces the pause from minutes to a matter of
seconds (with 4GB of swap), but it is still there (there was previously
no discernable delay).
Tested-by: Nigel Cunningham <nigel@xxxxxxxxxxxx>
Regards,
Nigel
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
