On 08/17/10 03:22, Jan Kara wrote: > On Thu 12-08-10 08:39:45, Randy Dunlap wrote: >> On 08/11/10 19:46, Jan Kara wrote: >>> On Wed 11-08-10 16:24:35, Randy Dunlap wrote: >>>> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >>>> >>>> warning: (GFS2_FS && BLOCK && EXPERIMENTAL && (64BIT || LBDAF)) selects QUOTACTL which has unmet direct dependencies (XFS_QUOTA || QUOTA) >>>> >>>> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx> >>>> Cc: Steven Whitehouse <swhiteho@xxxxxxxxxx> >>>> Cc: cluster-devel@xxxxxxxxxx >>>> --- >>>> fs/quota/Kconfig | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> However, the "depends on" line here seems like overkill to me. >>> OK, so do you mean that making QUOTACTL default to 'n', removing the >>> depends on line and letting QUOTA, XFS_QUOTA, and GFS2_QUOTA select >>> QUOTACTL would be better? >> >> Yes, I think that would be better. > OK, I've pushed the patch below to my tree. Thanks. Looks good. -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html