Re: [PATCH -next] quota: fix QUOTACTL kconfig for gfs2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed 11-08-10 16:24:35, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> 
> warning: (GFS2_FS && BLOCK && EXPERIMENTAL && (64BIT || LBDAF)) selects QUOTACTL which has unmet direct dependencies (XFS_QUOTA || QUOTA)
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Cc:	Steven Whitehouse <swhiteho@xxxxxxxxxx>
> Cc:	cluster-devel@xxxxxxxxxx
> ---
>  fs/quota/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> However, the "depends on" line here seems like overkill to me.
  OK, so do you mean that making QUOTACTL default to 'n', removing the
depends on line and letting QUOTA, XFS_QUOTA, and GFS2_QUOTA select
QUOTACTL would be better?

								Honza
> 
> 
> --- linux-next-20100810.orig/fs/quota/Kconfig
> +++ linux-next-20100810/fs/quota/Kconfig
> @@ -65,7 +65,7 @@ config QFMT_V2
>  
>  config QUOTACTL
>  	bool
> -	depends on XFS_QUOTA || QUOTA
> +	depends on XFS_QUOTA || QUOTA || GFS2_FS
>  	default y
>  
>  config QUOTACTL_COMPAT
-- 
Jan Kara <jack@xxxxxxx>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux