Re: [PATCH] return EINVAL when thawing unfrozen filesystems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 28, 2010 at 02:10:34PM -0500, Eric Sandeen wrote:
> The iterate_supers() loop in do_thaw_all() assumes
> that we can call thaw_bdev() until we hit an error; when
> I wrote this, we got -EINVAL when requesting a thaw of
> an unfrozen bdev.  (it called until error because we
> may have nested freezes).
> 
> However, commit 4504230a (freeze_bdev: grab active
> reference to frozen superblocks) changed this so that
> we get a return of 0 in this case, and do_thaw_all()
> spins forever when an emergency system-wide thaw
> is requested.
> 
> It looks to me like the change was inadvertent,
> so this patch changes it back.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux