The iterate_supers() loop in do_thaw_all() assumes that we can call thaw_bdev() until we hit an error; when I wrote this, we got -EINVAL when requesting a thaw of an unfrozen bdev. (it called until error because we may have nested freezes). However, commit 4504230a (freeze_bdev: grab active reference to frozen superblocks) changed this so that we get a return of 0 in this case, and do_thaw_all() spins forever when an emergency system-wide thaw is requested. It looks to me like the change was inadvertent, so this patch changes it back. Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> --- diff --git a/fs/block_dev.c b/fs/block_dev.c index 99d6af8..51500f6 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -291,7 +291,7 @@ int thaw_bdev(struct block_device *bdev, struct super_block *sb) } out: mutex_unlock(&bdev->bd_fsfreeze_mutex); - return 0; + return error; } EXPORT_SYMBOL(thaw_bdev); -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
