On Tue, Jun 29, 2010 at 06:57:59PM +1000, Nick Piggin wrote: > On Mon, Jun 28, 2010 at 12:52:56PM -0700, Ulrich Drepper wrote: > > -----BEGIN PGP SIGNED MESSAGE----- > > Hash: SHA1 > > > > On 06/28/2010 11:43 AM, Andreas Dilger wrote: > > > I would advocate at least an 8-bit magic value, if there is a concern > > > about this field not always being 0-filled on older kernels, or not > > > using any ST_VALID flag at all, if it was always zero-filled in the > > > past. > > ST_VALID is required to differentiate between no flags, and > flags field unsupported of course. Yes, that was my intention for it. > > > spare fields (if any)? > > At least from 2.4.0 does memset it. 2.2.26 does not. Can you > live with that? The spare fields in struct statfs have been zeroed since 2.3.99pre3-8, before that they were set to a pattern of 0xff. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
