Suresh Jayaraman <sjayaraman@xxxxxxx> wrote: > + rc = cifs_fscache_register(); > + if (rc) > + goto out; > + > rc = cifs_init_inodecache(); > if (rc) > goto out_clean_proc; > @@ -949,8 +954,10 @@ init_cifs(void) > cifs_destroy_mids(); > out_destroy_inodecache: > cifs_destroy_inodecache(); > + cifs_fscache_unregister(); > out_clean_proc: This is incorrect. You need to call cifs_fscache_unregister() if cifs_init_inodecache() fails. David -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html