On 2010-06-18 18:58, Christoph Hellwig wrote: > On Fri, Jun 18, 2010 at 11:36:10AM +0200, Jens Axboe wrote: >> On 2010-06-18 09:46, Christoph Hellwig wrote: >>> Remove all the trivial wrappers for the cmd_type and cmd_flags fields in >>> struct requests. This allows much easier grepping for different request >>> types instead of unwinding through macros. >> >> Agree. I kind of liked it in the beginning, but it really just adds >> an extra layer of grep or cscope stack when you forget what it >> checks specifically. >> >> Was this a scripted conversion? > > No. And as you already noticed I sent you the version before fixing > up the make allmodconfig fallout. Here's the fixed one: Ditto on this one, are there fixes in this one apart from the problems I posted? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
