Re: [PATCH 1/2] block: remove wrappers for request type/flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2010-06-18 09:46, Christoph Hellwig wrote:
> Remove all the trivial wrappers for the cmd_type and cmd_flags fields in
> struct requests.  This allows much easier grepping for different request
> types instead of unwinding through macros.

Agree. I kind of liked it in the beginning, but it really just adds
an extra layer of grep or cscope stack when you forget what it
checks specifically.

Was this a scripted conversion?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux