Re: [patch] fs: fix superblock iteration race

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 11, 2010 at 8:57 PM, Nick Piggin <npiggin@xxxxxxx> wrote:
>
> Something like this
>
>  fs/dcache.c |   14 ++++++++++++--
>  fs/super.c  |   51 +++++++++++++++++++++++++++++++++++++++++++++------
>  2 files changed, 57 insertions(+), 8 deletions(-)

Ok, I have to admit that I didn't expect it to blow up quite that
badly - I thought it would add a line or two, not 50.

So wow I wonder if we should use your old approach instead, just make
it an 'official' thing. IOW, maybe we can use
"list_for_each_entry_safe()" after all, but simply introduce a
"reset_next_entry()" helper or something and make that be part of the
"calling convention" for those things.

But I can live with the open-coded version too. It just is a bit more
code than I thought it would be.

Anybody? I don't really have very strong opinions.

                         Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux