On Fri, Jun 11, 2010 at 12:50:20AM -0700, Joel Becker wrote: > On Fri, Jun 11, 2010 at 09:19:45AM +0200, Christoph Hellwig wrote: > > On Fri, Jun 11, 2010 at 03:16:13PM +0800, Tao Ma wrote: > > > oh, that would be much work for ocfs2 to do from my perspective. So I > > > would really want to leave it as-is and I have add it to my to-do list. > > > > Oh right, you start a new transaction there. Sorry, ignore my request > > and keep it as it is for now. I don't think doing truncatate in separate > > transactions actually is correct, though but that's no change with this > > patch. > > Christoph, > You're missing the part where actual truncate (reduce i_size) > sets i_size in ocfs2_truncate_file(). So this later code doesn't get > triggered for the truncate case. It exists for the extend case, where > we extend the allocation in multiple clean transactions, then finally > set i_size in a final transaction. Actually, ocfs2_extend_file() appears to handle it too. I don't think it used to - there were places that had issues with commit_write()'s update of i_size, etc. But that's ancient history. I wonder if Mark knows. joel -- Dort wo man Bücher verbrennt, verbrennt man am Ende auch Mensch. (Wherever they burn books, they will also end up burning people.) - Heinrich Heine Joel Becker Principal Software Developer Oracle E-mail: joel.becker@xxxxxxxxxx Phone: (650) 506-8127 -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
