On Fri, Jun 11, 2010 at 03:16:13PM +0800, Tao Ma wrote: > Hi Christoph, > > On 06/11/2010 02:56 PM, Christoph Hellwig wrote: > >This looks correct, but still has the second if ATTR_SIZE block that > >I commented on last time. I'd really prefer if the filesystems could > >move the truncate handling into a single conditional to simplify > >auditing for it and possibly splitting it out into a separate method > >later. > oh, that would be much work for ocfs2 to do from my perspective. So I > would really want to leave it as-is and I have add it to my to-do list. Oh right, you start a new transaction there. Sorry, ignore my request and keep it as it is for now. I don't think doing truncatate in separate transactions actually is correct, though but that's no change with this patch. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
