On 06/09/2010 04:55 PM, Christoph Hellwig wrote:
>> + if (unlikely(ret)) {
>> + struct inode *inode = mapping->host;
>> + loff_t to = pos + len;
>>
>> + if (to > inode->i_size)
>> + truncate_pagecache(inode, to, inode->i_size);
>> + }
>
> Might be worth to add a exofs_write_failed helper similar to ext2 that
> can be shared with write_end, and once added ->direct_IO?
>
>> + error = inode_newsize_ok(inode, iattr->ia_size);
>> + if (unlikely(error))
>> + return error;
>
> This has been folded into inode_change_ok in vfs.git #for_next, you
> can drop it.
>
Christoph didn't you have a patch to simple_write_end, is it in vfs/for-next
This patch adds this comment:
+ /* TODO: once simple_write_end marks inode dirty remove */
if (i_size != inode->i_size)
mark_inode_dirty(inode);
Please CC me on that patch
Thanks for the review
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
