Re: [PATCH 2/58] unify fs/inode.c callers of clear_inode()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +static void evict(struct inode *inode, int delete)

How about calling this evict_inode?  That gives a better grepable
identifier in backtraces and also fits the tradition of other
wrappers for methods.

> +{
> +	const struct super_operations *op = inode->i_sb->s_op;
> +
> +	if (delete && op->delete_inode) {
> +		op->delete_inode(inode);

What's the point in having the local op variable?

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux