Le jeudi 03 juin 2010 à 21:16 +0900, Takuya Yoshikawa a écrit : > (2010/06/03 20:59), Jens Axboe wrote: > > On 2010-06-03 12:35, Dan Carpenter wrote: > >> copy_to_user() returns the number of bytes remaining, but we want to > >> return -EFAULT. > >> ret = fcntl(fd, F_SETOWN_EX, NULL); > >> With the original code ret would be 8 here. > >> > >> V2: Takuya Yoshikawa pointed out a similar issue in f_getown_ex() > > > > Pretty basic bug, how long has this been there? > > IIUC, from the beginning, when these were introduced. Maybe copy_to_user() was changed sometime to return a partial count instead of EFAULT ? I do think we should have a set of helper functions, instead of spreading special EFAULT cases in one housand places... This is really ugly. static inline int sec_copy_to_user(arg1, arg2, arg3) { int res = copy_to_user(arg1, arg2, arg3); return (res > 0) ? -EFAULT : res; } -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html