Re: [patch v2] fix truncate inode time modification breakage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/03/2010 12:05 PM, Miklos Szeredi wrote:
> On Thu, 03 Jun 2010, Boaz Harrosh wrote:
>>> Fuse philosophy is: each operation itself has to update times on files
>>> if necessary.  So it basically moves the responsibility to update
>>> [amc]time from the VFS into the filesystem.
>>>
>>> This means the only place fuse is interested in ATTR_ATIME or
>>> ATTR_MTIME is for the utime* syscalls.
>>>
>>> It also means that fuse always ignores ATTR_CTIME which is never set
>>> explicitly.
>>>
>>> So I believe the current fuse code is correct.
>>>
>>
>> It might be correct, but there were reports it has problems with NFS export.
> 
> Do you have details?  I can't remember any report related to time
> modification and NFS export.
> 
>> Why let the filesystems be broken? Why not do the common stuff
>> common? (In VFS)
> 
> For consistency and simplicity.  The fuse API looks much like the
> syscall API, which means that for a truncate() call on a fuse file the
> truncate() method will be called in the filesystem, not a truncate() +
> utimes().  And so on...
> 

OK So that has now changed there is a ->setattr from VFS ->truncate is
been killed. And the VFS could be trusted to do what it knows how to do?
(I think)

> Thanks,
> Miklos

Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux