On Wed, Jun 02, 2010 at 01:50:12PM +1000, Nick Piggin wrote: > On Wed, Jun 02, 2010 at 12:28:24PM +0900, Tetsuo Handa wrote: > > When commit be6d3e56a6b9b3a4ee44a0685e39e595073c6f0d "introduce new LSM hooks > > where vfsmount is available." was proposed, regarding security_path_truncate(), > > only "struct file *" argument (which AppArmor wanted to use) was removed. > > But length and time_attrs arguments are not used by TOMOYO nor AppArmor. > > Well if length is not used either, can we remove that too seeing as > we're changing the API anyway. > > Length would also be an iffy thing to use here because we're not > holding the i_mutex, so it may change between being checked and > truncate checking it. To clarify, not the length of course, but the i_size. That could be a problem if a security module thought it could allow only expanding truncates by checking i_size, for example. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
