Re: [PATCH] LSM: Remove unused time_attrs argument.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 02, 2010 at 12:28:24PM +0900, Tetsuo Handa wrote:
> When commit be6d3e56a6b9b3a4ee44a0685e39e595073c6f0d "introduce new LSM hooks
> where vfsmount is available." was proposed, regarding security_path_truncate(),
> only "struct file *" argument (which AppArmor wanted to use) was removed.
> But length and time_attrs arguments are not used by TOMOYO nor AppArmor.

Well if length is not used either, can we remove that too seeing as
we're changing the API anyway.

Length would also be an iffy thing to use here because we're not
holding the i_mutex, so it may change between being checked and
truncate checking it.


> Thus, let's remove time_attrs argument.
> 
> Signed-off-by: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> ---
>  fs/namei.c               |    3 +--
>  fs/open.c                |    5 ++---
>  include/linux/security.h |   10 +++-------
>  security/capability.c    |    3 +--
>  security/security.c      |    5 ++---
>  security/tomoyo/tomoyo.c |    3 +--
>  6 files changed, 10 insertions(+), 19 deletions(-)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux