On Tue, Jun 01, 2010 at 09:49:51AM -0400, Chris Mason wrote: > > I agree that a block based retry would close all the holes ... it just > > doesn't look elegant to me that the fs will already be repeating the I/O > > if it changed the page and so will block. > > We might not ever repeat the IO. We might change the page, write it, > change it again, truncate the file and toss the page completely. Why does it matter that it was never written in that case? -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html