Re: [PATCH ver2] exofs: exofs_file_fsync and exofs_file_flush correctness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 01, 2010 at 07:11:06PM +0300, Boaz Harrosh wrote:
> +/* exofs_file_fsync - flush the inode to disk
> + *
> + *   @datasync is not used. All metadata is written in one place regardless.
> + *   the writeout is synchronous
> + */

It actually is used now :)

>  static int exofs_flush(struct file *file, fl_owner_t id)
>  {
> -	exofs_file_fsync(file, 1);
> +	int ret = vfs_fsync_range(file, 0, LLONG_MAX, 0);
>  	/* TODO: Flush the OSD target */
> -	return 0;
> +	return ret;

why not just:

	return vfs_fsync(file, 0);

--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Ext4 Filesystem]     [Union Filesystem]     [Filesystem Testing]     [Ceph Users]     [Ecryptfs]     [AutoFS]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux Cachefs]     [Reiser Filesystem]     [Linux RAID]     [Samba]     [Device Mapper]     [CEPH Development]
  Powered by Linux