On Mon, May 31, 2010 at 04:46:33PM +0300, Boaz Harrosh wrote: > You think I also need a: > if (!(inode->i_state & I_DIRTY)) > return ret; > if (datasync && !(inode->i_state & I_DIRTY_DATASYNC)) > return ret; > before the write_inode_now call ? You don't strictly need it, but without it you will perform a lot of work for no gain if the inode is not actually dirty. -- To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html